forked from fluent/fluent-bit
-
Notifications
You must be signed in to change notification settings - Fork 1
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
adds entity to PLE calls in cloudwatch logs plugin when used in EKS with kubernetes filter #2
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…uent#5929)" This reverts commit 300206a.
Signed-off-by: Matthew Fala <[email protected]>
Signed-off-by: Matthew Fala <[email protected]>
Signed-off-by: Matthew Fala <[email protected]>
Signed-off-by: Clay Cheng <[email protected]>
…e output. Signed-off-by: Clay Cheng <[email protected]>
…me output. Signed-off-by: Clay Cheng <[email protected]>
Signed-off-by: Wesley Pettit <[email protected]>
fluent#6614 1.9 based branch Signed-off-by: Wesley Pettit <[email protected]>
Signed-off-by: Matthew Fala <[email protected]>
Signed-off-by: Matthew Fala <[email protected]>
Signed-off-by: Wesley Pettit <[email protected]>
Signed-off-by: Wesley Pettit <[email protected]>
Signed-off-by: Wesley Pettit <[email protected]>
Resolves this issue: fluent#6821 Signed-off-by: Wesley Pettit <[email protected]>
prepare_destroy_conn calls mk_list_del on the event in the priority bucket queue, so for safety, we inject it after this covers us against the case where the event was triggered and waiting, but we also reached the timeout. Signed-off-by: Wesley Pettit <[email protected]>
… everywhere with MK_EVENT_ZERO Signed-off-by: Wesley Pettit <[email protected]>
this message is very useful in debugging Fluent Bit log loss or frozen. But it needs context on which input the append happened for. Signed-off-by: Wesley Pettit <[email protected]>
These messages are useful for debugging except with only the inode, it you have to do work to match this with specific files. Signed-off-by: Wesley Pettit <[email protected]>
Signed-off-by: Wesley Pettit <[email protected]>
Signed-off-by: Wesley Pettit <[email protected]>
…t#6719) Signed-off-by: Wesley Pettit <[email protected]>
Signed-off-by: Wesley Pettit <[email protected]>
Signed-off-by: Matthew Fala <[email protected]>
Signed-off-by: Wesley Pettit <[email protected]>
Signed-off-by: Wesley Pettit <[email protected]>
Signed-off-by: Wesley Pettit <[email protected]>
Signed-off-by: Wesley Pettit <[email protected]>
chadpatel
approved these changes
Oct 21, 2024
swapneils
requested changes
Oct 21, 2024
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Some blocking questions and code-changes, please take a look.
Non-blocking points are prefixed as "Nit"
…te-fluent-bit into add-entity
swapneils
pushed a commit
that referenced
this pull request
Oct 22, 2024
…ch Agent Adds Use_Pod_association option. When running in a kubernetes container, setting this option to On vends an `entity` object with pod metadata from CWA to a cloudwatch_logs output with the new `add_entity` option set to true. (PR #2 in amazon-contributing/upstream-to-fluent-bit)
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Enter
[N/A]
in the box, if an item is not applicable to your change.Testing
Before we can approve your change; please submit the following in a comment:
If this is a change to packaging of containers or native binaries then please confirm it works for all targets.
ok-package-test
label to test for all targets (requires maintainer to do).N/A
Documentation
Backporting
N/A
Fluent Bit is licensed under Apache 2.0, by submitting this pull request I understand that this code will be released under the terms of that license.